Fix rollingRestart reconcile for multiple same named clusters #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Engel <[email protected]>
OlegVanHorst
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
Hi @OlegVanHorst. Thanks for noticing this and providing a fix. Would you mind extending your PR and also making the same fix for the |
Signed-off-by: Alex Engel <[email protected]>
|
Hi @swoehrl-mw |
swoehrl-mw
approved these changes
Aug 7, 2024
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…arch-project#836) ### Description Fixes a bug where reconcile breaks, if there are multiple same named OpensearchClusters in different namespaces. The rollingRestart reconciler selects pods in all namespaces when evaluating if the Pods are healthy and matches them with the desired replicas. Only pods in the own namespace should be checked. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Alex Engel <[email protected]>
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…arch-project#836) ### Description Fixes a bug where reconcile breaks, if there are multiple same named OpensearchClusters in different namespaces. The rollingRestart reconciler selects pods in all namespaces when evaluating if the Pods are healthy and matches them with the desired replicas. Only pods in the own namespace should be checked. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Alex Engel <[email protected]>
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…arch-project#836) ### Description Fixes a bug where reconcile breaks, if there are multiple same named OpensearchClusters in different namespaces. The rollingRestart reconciler selects pods in all namespaces when evaluating if the Pods are healthy and matches them with the desired replicas. Only pods in the own namespace should be checked. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Alex Engel <[email protected]> Signed-off-by: rkthtrifork <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where reconcile breaks, if there are multiple same named OpensearchClusters in different namespaces.
The rollingRestart reconciler selects pods in all namespaces when evaluating if the Pods are healthy and matches them with the desired replicas. Only pods in the own namespace should be checked.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.