Support projected volumes as additionalVolumes #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Brenton <[email protected]>
Capitrium
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
Signed-off-by: Zack Brenton <[email protected]>
Signed-off-by: Zack Brenton <[email protected]>
Capitrium
force-pushed
the
feature/projected-volumes
branch
from
b329572 to
e031d22
Compare
swoehrl-mw
approved these changes
May 13, 2024
swoehrl-mw
changed the title
|
Thanks @Capitrium and @swoehrl-mw. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows using a projected volume under
spec.general.additionalVolumes.My specific use case is to allow using a
serviceAccountTokenmount to enable AWS IAM Roles for service accounts on EKS (and EC2) clusters, though I'm sure there are others.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Fixes #459
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.