-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add datastream support #735
add datastream support #735
Conversation
33cddae
to
d55bdf4
Compare
d55bdf4
to
d1addb6
Compare
Great! I would love this feature in the next coming release! (perhaps 2.5.2? #749) |
@cthtrifork As this is a new feature, I think the 2.6.0 version is better. @idanl21 Can you please review this pull request? |
Thanks @cgroschupp for your contribution, before we get this PR merged, can you please open an issue summarizing the datastream support in detail? This way your contribution is tracked in the issue and later we can link this PR to the issue. Adding @bbarani @salyh @jochenkressin @pchmielnik @swoehrl-mw |
@prudhvigodithi done |
@cgroschupp Before we can get this PR merged, please refer to the PR guideline and add the mssing prerequisites. Thank you very much. |
Hey @cgroschupp we can push this to |
Signed-off-by: Christian Groschupp <[email protected]>
21902d3
to
fad542a
Compare
Signed-off-by: Christian Groschupp <[email protected]>
Signed-off-by: Christian Groschupp <[email protected]>
fad542a
to
2973c9f
Compare
@prudhvigodithi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One gripe about naming, everything else looks good
|
||
type OpensearchDatastreamSpec struct { | ||
// TimestampField for dataStream | ||
TimestampField OpensearchDatastreamTimestampFieldSpec `json:"timestamp_field,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every other field is camelCase, so this should as well to be consistent
eba54ab
to
2d1982c
Compare
2d1982c
to
a058ed7
Compare
Description
Add DataStream support to IndexTemplate.
Close #766