Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-k3d-k3s functional tests #729

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Feb 13, 2024

Description

Fix the error running Functional tests with open PR's.

Error: No matching K3s versions were found.
Error: Process completed with exit code 1

Example: https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/7890709537/job/21543655443?pr=728

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Member Author

Adding @swoehrl-mw

Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original idea was to test against the oldest kubernetes version we want to support. But checking against the newest probably makes more sense now to verify nothing breaks with new versions.

@prudhvigodithi prudhvigodithi merged commit c3d2a79 into opensearch-project:main Feb 14, 2024
6 checks passed
trondhindenes pushed a commit to trondhindenes/opensearch-k8s-operator that referenced this pull request Feb 15, 2024
### Description
Fix the error running Functional tests with open PR's.
```
Error: No matching K3s versions were found.
Error: Process completed with exit code 1
```

Example:
https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/7890709537/job/21543655443?pr=728

### Issues Resolved
_List any issues this PR will resolve, e.g. Closes [...]._ 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Prudhvi Godithi <[email protected]>
swoehrl-mw pushed a commit to MaibornWolff/opensearch-operator that referenced this pull request Apr 25, 2024
### Description
Fix the error running Functional tests with open PR's.
```
Error: No matching K3s versions were found.
Error: Process completed with exit code 1
```

Example:
https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/7890709537/job/21543655443?pr=728

### Issues Resolved
_List any issues this PR will resolve, e.g. Closes [...]._

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Sebastian Woehrl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants