Add probes config #728
Merged
Add probes config #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vipin Jain <[email protected]>
Signed-off-by: Vipin Jain <[email protected]>
Signed-off-by: Vipin Jain <[email protected]>
Signed-off-by: Vipin Jain <[email protected]>
Signed-off-by: Vipin Jain <[email protected]>
vipinjn24
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
I am not a go developer, so please verify that my code is good for the operator. If not please let me know the short comings. Also requesting to please release this change as soon as possible as the cluster nodes restarts more than 20 times to spin up correctly. |
Signed-off-by: Vipin Jain <[email protected]>
|
@prudhvigodithi what is the timeline we follow to merge the pull requests? will it take more time though? |
|
Thanks for your contribution @vipinjn24 this is a good change, usually the pull requests are reviewed and merged soon as a maintainer is available. The repository recently transitioned from the Opster organization to the opensearch-project organization, and efforts are underway to streamline its operations. |
vipinjn24
force-pushed
the
add-probes-config
branch
from
0f4ada9 to
236fe44
Compare
Signed-off-by: Vipin Jain <[email protected]>
prudhvigodithi
approved these changes
Feb 26, 2024
prudhvigodithi
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes hardcoding of the timeouts and thresholds of probes used in nodepools.
Issues Resolved
Closes 418
Closes 691
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.