Searchable snapshots GA #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the announcement here https://github.com/opensearch-project/opensearch-build/blob/main/release-notes/opensearch-release-notes-2.7.0.md This means the experimental flag only needs to be added if version is less than 2.7.0 Signed-off-by: Rhys Evans <[email protected]>
idanl21
approved these changes
May 4, 2023
|
@rhysxevans |
swoehrl-mw
requested changes
May 5, 2023
Signed-off-by: Rhys Evans <[email protected]>
idanl21
previously approved these changes
May 10, 2023
swoehrl-mw
requested changes
May 11, 2023
Comment on lines
254
to
257
| if err == nil && ver1.LessThan(ver2) { | ||
| lessThan = true | ||
| } | ||
| return lessThan |
There was a problem hiding this comment.
Can be written shorter:
Suggested change
| if err == nil && ver1.LessThan(ver2) { | |
| lessThan = true | |
| } | |
| return lessThan | |
| return err == nil && ver1.LessThan(ver2) |
There was a problem hiding this comment.
Hi @swoehrl-mw, I have made the changes requested, please let me know if there is anything else
Signed-off-by: Rhys Evans <[email protected]>
swoehrl-mw
approved these changes
May 12, 2023
|
This feature is GA In 2.7 https://opensearch.org/blog/searchable-snapshots/, should we consider removing the experimental flag? |
This PR already dealt with not using the feature flag for 2.7+. And as long as the operator also supports older opensearch versions we will need to keep the logic to add the feature flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the announcement here https://github.com/opensearch-project/opensearch-build/blob/main/release-notes/opensearch-release-notes-2.7.0.md This means the experimental flag only needs to be added if version is less than 2.7.0