Make optional fields optional in MappingGenericProperty (#703)

[alex-at-cascade]

Description

Make optional fields optional in MappingGenericProperty

Issues Resolved

#703

Check List

• New functionality includes testing.
  • All tests pass
• Linter check was successfull - yarn run lint doesn't show any errors
• Commits are signed per the DCO using --signoff
• Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[nhtruong]

Thanks, @alex-at-cascade
Would you mind signing your commit as well? https://github.com/opensearch-project/opensearch-js/pull/708/checks?check_run_id=20998375185

[alex-at-cascade]

Thanks, @alex-at-cascade Would you mind signing your commit as well? https://github.com/opensearch-project/opensearch-js/pull/708/checks?check_run_id=20998375185

If you look at the commit message, it seems to have the proper line - is the automation confused because I used my real name there (instead of my github username)? The contributing guide does say "please use your real name" for that line.

[nhtruong]

I believe it's expecting your github user name:

Expected "alex-at-cascade [email protected]", but got "Alex Dommasch [email protected]".

[alex-at-cascade]

I believe it's expecting your github user name:

Expected "alex-at-cascade [email protected]", but got "Alex Dommasch [email protected]".

But https://github.com/opensearch-project/opensearch-js/blob/main/CONTRIBUTING.md says very clearly:

Additionally, please use your real name. We do not accept anonymous contributors nor those utilizing pseudonyms.

Is that guide inaccurate? (I just want to do the right thing here.)

[nhtruong]

@alex-at-cascade Hey sorry for the late response. I was out the last few days.

You're correct. However the DCO is based off of your github info. In this case, your email address already reflects your name. You can also update your github account to your real name. The goal of the DCO is helping us identifying the contributor, and I think yours is satisfactory :)