Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types for AwsSigv4SignerOptions.service #377

Merged
merged 3 commits into from
Feb 14, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: service is optional
Signed-off-by: magoz <apps@magoz.is>
magoz committed Feb 14, 2023
commit f4e9e043c1ae9c62e50113cd7708949bf8f6276c
2 changes: 1 addition & 1 deletion lib/aws/index.d.ts
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ import { OpenSearchClientError } from '../errors';
interface AwsSigv4SignerOptions {
getCredentials?: () => Promise<Credentials>;
region: string;
service: 'es' | 'aoss';
service?: 'es' | 'aoss';
}

interface AwsSigv4SignerResponse {