-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eslint and prettier and apply #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit and integration:
|
sanity test:
|
ananzh
force-pushed
the
format
branch
2 times, most recently
from
May 20, 2022 20:17
59133cd
to
9ab3d03
Compare
kavilla
reviewed
May 20, 2022
5 tasks
tmarkley
reviewed
May 23, 2022
tmarkley
approved these changes
May 24, 2022
* add prettier and apply prettier * add eslint and its config; apply eslint * modify package.json script * turn off no-unused-vars and no-dupe-else-if. will fix them in separate PRs * modify workflow to run yarn lint for restricter format check * remove standard Issue Resolved: opensearch-project#243 Signed-off-by: Anan Zhuang <[email protected]> remove yarn from devDependency and add it as engine Signed-off-by: Ubuntu <[email protected]> fix merge conflict Signed-off-by: Anan Zhuang <[email protected]>
VachaShah
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Resolved:
#243
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.