Add support to test against multiple versions of OpenSearch #228
Conversation
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
|
Hello, can i already consider this compatibility matrix as truth? |
Correct. Generally, we're following semver and ensuring there's an easy upgrade path that does not require upgrading in lockstep. Please do check out opensearch-project/opensearch-clients#17 and add your comments! |
.github/workflows/compatibility.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| entry: | ||
| - { version: '1.1.0', secured: 'true' } |
There was a problem hiding this comment.
May be Im totally off, I see we are replicating few pieces of code (workflows, compatibility etc ) in all client repositories.
Is there a way we can define these in a single place (May be opensearch-clients) which is the source of truth and consume it in all our client repos?
There was a problem hiding this comment.
Looks like you found a really nice way to do this in https://github.com/opensearch-project/opensearch-py/pull/163/files @VachaShah - want to update it here?
There was a problem hiding this comment.
@dblock Updated the workflow matrix.
There was a problem hiding this comment.
@saratvemulapalli Do you mean like having a template in opensearch-clients?
There was a problem hiding this comment.
I dont know what a template is :/.
I was looking for a single place where common code can live. Lets take compatibility as an example:
- Defining this in a central place will make it easier when we add new version support.
- Enforces our CIs to test against new versions.
- Keeps all clients in sync.
There was a problem hiding this comment.
Oh got it! Yeah we are trying to keep it as consistent as possible across the client repos but I will keep this in mind if we can place common code. My current thought is having a single place might be difficult since the clients can be on different versions with different compatibility, their CIs are written differently etc. But will explore this once the breaking changes are done.
Signed-off-by: Vacha Shah <[email protected]>
* Expand test matrix to include multiple versions of OpenSearch Signed-off-by: Vacha Shah <[email protected]> * Add a compatibility matrix Signed-off-by: Vacha Shah <[email protected]> * Updating the github workflow matrix Signed-off-by: Vacha Shah <[email protected]> (cherry picked from commit f62a8cd)
) * Expand test matrix to include multiple versions of OpenSearch Signed-off-by: Vacha Shah <[email protected]> * Add a compatibility matrix Signed-off-by: Vacha Shah <[email protected]> * Updating the github workflow matrix Signed-off-by: Vacha Shah <[email protected]> (cherry picked from commit f62a8cd) Co-authored-by: Vacha Shah <[email protected]>
Description
Adding support to run tests against multiple versions of OpenSearch in the CI. I separated out the
compatibility.ymlsince the matrix was becoming huge in theintegration.ymlwith multiple node js versions.Issues Resolved
#214
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.