Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] OpenSearchDashboardsClient missing #181

Closed
kavilla opened this issue Sep 30, 2021 · 0 comments · Fixed by #183
Closed

[BUG] OpenSearchDashboardsClient missing #181

kavilla opened this issue Sep 30, 2021 · 0 comments · Fixed by #183
Assignees
@ananzh
Labels
🐛 bug Something isn't working

Comments

@kavilla
Copy link
Member

kavilla commented Sep 30, 2021

What is the bug?
OpenSearchDashboardsClient was accidentally removed in this commit, should have been renamed from KibanaClient to OpenSearchDashboardsClient.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. install opensearch-project/opensearch
  2. try to import OpenSearchDashboardsClient in this file

What is the expected behavior?
Should have access and be able to run
@kavilla kavilla added the 🐛 bug Something isn't working label Sep 30, 2021
@ananzh ananzh self-assigned this Sep 30, 2021
ananzh added a commit to ananzh/opensearch-js-1 that referenced this issue Oct 1, 2021
@ananzh
add back OpenSearchDashboardsClient types
2cbea0b 
PR solved:
opensearch-project#181

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/opensearch-js-1 that referenced this issue Oct 1, 2021
@ananzh
add back OpenSearchDashboardsClient types
b8231ae 
PR solved:
opensearch-project#181

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh mentioned this issue Oct 1, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request Oct 5, 2021 that will close this issue
add back OpenSearchDashboardsClient types #183
Merged
5 tasks
ananzh added a commit that referenced this issue Oct 6, 2021
@ananzh
add back OpenSearchDashboardsClient types (#183)
437a243 
* add back OpenSearchDashboardsClient types

PR solved:
#181

Signed-off-by: Anan Zhuang <[email protected]>

* Re-direct opensearch-js issue

Signed-off-by: Anan Zhuang <[email protected]>
@kavilla kavilla mentioned this issue Oct 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add back OpenSearchDashboardsClient types ananzh/opensearch-js-1
2 participants
@kavilla @ananzh