Make optional fields optional in MappingGenericProperty (#703)

Signed-off-by: Alex Dommasch <[email protected]>

CHANGELOG.md

@@ -14,6 +14,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ### Deprecated
 ### Removed
 ### Fixed
+- Make optional fields optional in `MappingGenericProperty`
 ### Security
 
 ## [2.5.0]

api/types.d.ts

@@ -3907,17 +3907,17 @@ export interface MappingFloatRangeProperty extends MappingRangePropertyBase {
 }
 
 export interface MappingGenericProperty extends MappingDocValuesPropertyBase {
-  analyzer: string;
-  boost: double;
-  fielddata: IndicesStringFielddata;
-  ignore_malformed: boolean;
-  index: boolean;
-  index_options: MappingIndexOptions;
-  norms: boolean;
-  null_value: string;
-  position_increment_gap: integer;
-  search_analyzer: string;
-  term_vector: MappingTermVectorOption;
+  analyzer?: string;
+  boost?: double;
+  fielddata?: IndicesStringFielddata;
+  ignore_malformed?: boolean;
+  index?: boolean;
+  index_options?: MappingIndexOptions;
+  norms?: boolean;
+  null_value?: string;
+  position_increment_gap?: integer;
+  search_analyzer?: string;
+  term_vector?: MappingTermVectorOption;
   type: string;
 }
 

test/types/types.test-d.ts

@@ -0,0 +1,10 @@
+import { expectAssignable } from 'tsd';
+import { MappingProperty } from '../../api/types';
+
+// https://github.com/opensearch-project/opensearch-js/issues/703
+// only manifested when value is in a variable, so the following would *not* catch it:
+//
+// expectAssignable<MappingProperty>({ type: 'date' });
+
+const x = { type: 'date' };
+expectAssignable<MappingProperty>(x);