Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7 #69

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Update to Gradle 7 #69

merged 3 commits into from
Jan 7, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 30, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Update to Gradle 7

Issues Resolved

Closes #67

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Nov 30, 2021

@dblock if you don't mind this one please, thank you

mitalawachat
mitalawachat previously approved these changes Dec 3, 2021
imRishN
imRishN previously approved these changes Dec 6, 2021
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

vamshin
vamshin previously approved these changes Dec 6, 2021
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

reta added 2 commits December 23, 2021 09:13
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Collaborator Author

reta commented Dec 23, 2021

@vamshin @dblock @VijayanB sorry guys, mind taking a look? thank you

# Modifications Copyright OpenSearch Contributors. See
# GitHub history for details.
#

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing the right thing removing the ES license here? We typically leave these alone.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm ... unexpected glitch in the editor, sorry about that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks @dblock !

Signed-off-by: Andriy Redko <[email protected]>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@reta
Copy link
Collaborator Author

reta commented Jan 7, 2022

@vamshin @dblock could we merge this one? thank you!

@dblock dblock merged commit 2da1600 into opensearch-project:main Jan 7, 2022
VachaShah pushed a commit to VachaShah/opensearch-java that referenced this pull request Mar 10, 2022
* Update to Gradle 7

Signed-off-by: Andriy Redko <[email protected]>

* Update to Gradle 7.3.3

Signed-off-by: Andriy Redko <[email protected]>

* Restored copyright header

Signed-off-by: Andriy Redko <[email protected]>
This was referenced Mar 10, 2022
reta added a commit to reta/opensearch-java that referenced this pull request Mar 10, 2022
* Update to Gradle 7

Signed-off-by: Andriy Redko <[email protected]>

* Update to Gradle 7.3.3

Signed-off-by: Andriy Redko <[email protected]>

* Restored copyright header

Signed-off-by: Andriy Redko <[email protected]>
peternied pushed a commit that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Gradle 7
5 participants