-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "smartcn" analyzer. #605
Conversation
5d0e6f1
to
3ae2698
Compare
Signed-off-by: pieper <[email protected]>
Signed-off-by: pieper <[email protected]>
3ae2698
to
412643a
Compare
java-client/src/main/java/org/opensearch/client/opensearch/_types/analysis/SmartcnAnalyzer.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/opensearch/client/opensearch/_types/analysis/SmartcnStopTokenFilter.java
Show resolved
Hide resolved
...-client/src/main/java/org/opensearch/client/opensearch/_types/analysis/SmartcnTokenizer.java
Show resolved
Hide resolved
Signed-off-by: pieper <[email protected]>
Signed-off-by: pieper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Can we also add the different analyzers in the user guide?
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-605-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e68c3149741b2a4bec5df04f19a6b04c9b01c21
# Push it to GitHub
git push --set-upstream origin backport/backport-605-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Added "smartcn" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Fixed release number. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> (cherry picked from commit 1e68c31)
* Added "smartcn" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Fixed release number. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> (cherry picked from commit 1e68c31)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-605-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e68c3149741b2a4bec5df04f19a6b04c9b01c21
# Push it to GitHub
git push --set-upstream origin backport/backport-605-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Added "smartcn" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Fixed release number. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]>
* Added "smartcn" analyzer. (#605) * Added "smartcn" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Fixed release number. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> * Added "cjk" analyzer. (#604) * Added "cjk" analyzer. Signed-off-by: pieper <[email protected]> * Adapted changelog. Signed-off-by: pieper <[email protected]> * Fixed license headers. Signed-off-by: pieper <[email protected]> * Tab vs. Spaces fix. Signed-off-by: pieper <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: pieper <[email protected]> Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: MikePieperSer <[email protected]>
Description
Adds support for "smartcn" analyzer from smartcn-plugin.
Issues Resolved
Closes #593
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.