Update literature around changelog #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
feature/changelog
branch
from
be8bb45 to
f815c22
Compare
harshavamsi
changed the title
saratvemulapalli
previously approved these changes
Oct 14, 2022
dblock
requested changes
Oct 14, 2022
CONTRIBUTING.md
Outdated
|
|
||
|
|
||
| ### How to add my changes to [CHANGELOG](CHANGELOG.md)? | ||
| ### Adding changes |
There was a problem hiding this comment.
Should be "Adding Changes" to be consistent (capital C)
CONTRIBUTING.md
Outdated
| @@ -84,17 +84,17 @@ You may type this line on your own when writing your commit messages. However, i | |||
|
|
|||
| ## Changelog | |||
|
|
|||
| OpenSearch-Java maintains version specific changelog by enforcing a change to the ongoing [CHANGELOG](CHANGELOG.md) file adhering to the [Keep A Changelog](https://keepachangelog.com/en/1.0.0/) format. | |||
| OpenSearch-Java maintains a version specific changelog by enforcing a change to the ongoing [CHANGELOG](CHANGELOG.md) file adhering to the [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) format. | |||
There was a problem hiding this comment.
The project is Opensearch-java (capital O because start of sentence).
Version-specific I think has a -.
harshavamsi
force-pushed
the
feature/changelog
branch
from
798701b to
2e7689e
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
feature/changelog
branch
from
e7df453 to
b77c8e3
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
feature/changelog
branch
from
2a21d9c to
166ce0c
Compare
VachaShah
previously approved these changes
Oct 18, 2022
dblock
approved these changes
Oct 19, 2022
VachaShah
approved these changes
Oct 19, 2022
abhinav-nath
pushed a commit
to abhinav-nath/opensearch-java
that referenced
this pull request
Oct 21, 2022
* Update literature Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Removing pr template and updating language Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
abhinav-nath
pushed a commit
to abhinav-nath/opensearch-java
that referenced
this pull request
Oct 21, 2022
* Update literature Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Removing pr template and updating language Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Abhinav Nath <[email protected]>
VachaShah
pushed a commit
that referenced
this pull request
Oct 21, 2022
…#234) * Add support to parse sub-aggregations from filter/nested aggregations Signed-off-by: Abhinav Nath <[email protected]> * Add USER_GUIDE.md Signed-off-by: Abhinav Nath <[email protected]> * Add DCO Signed-off-by: Abhinav Nath <[email protected]> * Add link to USER_GUIDE.md in README.md Signed-off-by: Abhinav Nath <[email protected]> * Add changelog and changelog verifier (#239) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Set javadoc encoding to utf-8 (#50) (#241) Signed-off-by: Meetesh Kumawat<[email protected]> Signed-off-by: meetesh <[email protected]> Signed-off-by: Meetesh Kumawat<[email protected]> Signed-off-by: meetesh <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (#240) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Updates changelog for dependabot PRs (#247) * Updates changelog for dependabot PRs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding dependabot label for workflow Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Update tests to use JUnit's Assert (#244) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Update literature around changelog (#242) * Update literature Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Removing pr template and updating language Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> * Bump grgit-gradle from 4.0.1 to 5.0.0 (#243) * Bump grgit-gradle from 4.0.1 to 5.0.0 Bumps [grgit-gradle](https://github.com/ajoberstar/grgit) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/ajoberstar/grgit/releases) - [Commits](ajoberstar/grgit@4.0.1...5.0.0) --- updated-dependencies: - dependency-name: org.ajoberstar.grgit:grgit-gradle dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Abhinav Nath <[email protected]> * Add DCO Signed-off-by: Abhinav Nath <[email protected]> * Update CHANGELOG and README Signed-off-by: Abhinav Nath <[email protected]> * Add DCO Signed-off-by: Abhinav Nath <[email protected]> * Add DCO Signed-off-by: Abhinav Nath <[email protected]> * Fix CHANGLOG and README TOC Signed-off-by: Abhinav Nath <[email protected]> Signed-off-by: Abhinav Nath <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Meetesh Kumawat<[email protected]> Signed-off-by: meetesh <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Meetesh Kumawat <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Description
Introduces changelog and changelog verifier
Issues Resolved
[List any issues this PR will resolve]
Check List
docsfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.