Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic triggers to jenkins workflow #188

Merged
merged 8 commits into from
Jul 29, 2022

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jul 29, 2022

Description

  1. The maven release workflow runs only when a tag is pushed to this repository
  2. The maven snapshot release workflow runs when a commit is pushed to main branch only or if the workflow is run manually.

To-Do:
Before this PR is merged:

  1. Add webhook for public jenkins with token

After:
Create jobs for snapshot release and fix the jenkinsFile path for maven release

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gaiksaya added 5 commits July 28, 2022 16:36
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya requested review from a team and madhusudhankonda as code owners July 29, 2022 00:23
@gaiksaya gaiksaya requested a review from dblock July 29, 2022 00:24
Signed-off-by: Sayali Gaikawad <[email protected]>
checkout([
$class: 'GitSCM', userRemoteConfigs: [[url: 'https://github.com/opensearch-project/opensearch-java.git']],
branches: [[name: "$ref"]]
])
Copy link
Member

@dblock dblock Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra tab before ]), align ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Sayali Gaikawad <[email protected]>
dblock
dblock previously approved these changes Jul 29, 2022
@dblock dblock requested a review from saratvemulapalli July 29, 2022 00:46
Signed-off-by: Sayali Gaikawad <[email protected]>
checkout([
$class: 'GitSCM', userRemoteConfigs: [[url: 'https://github.com/opensearch-project/opensearch-java.git']],
branches: [[name: "$ref"]]
])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs vs. spaces strikes again!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a tab! I promise :)

Copy link
Member

@dblock dblock Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's why it looks weird. Make it all spaces! :) I was thinking it should align to the left side of checkout.

Feel free to merge at will anyway. Ignore me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GHA taking its sweet time to run workflows. Will do once everything is green. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs integ tests, you can just merge this since it doesn't touch any code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants