Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: user guide for aws sdk v2 signer #131

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

matelang
Copy link
Contributor

Signed-off-by: Máté Lang [email protected]

Description

Add documentation about the recently added AWS SDK v2 request signer.

Issues Resolved

Fixes #129.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

#### AWS SDK V2

```go
package main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the code formatting (like tabs/spaces) for all the examples in this file similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reformatted the whole document with standard GoLand formatting options. Hope it's okay.

VachaShah
VachaShah previously approved these changes Jun 22, 2022
@VachaShah
Copy link
Collaborator

Thank you @matelang for adding this! Can you sign off the DCO?

@matelang
Copy link
Contributor Author

Thank you @matelang for adding this! Can you sign off the DCO?

DCO added.

@VachaShah VachaShah self-requested a review June 23, 2022 17:04
@VachaShah VachaShah merged commit 27fa530 into opensearch-project:main Jun 23, 2022
igungor pushed a commit to igungor/opensearch-go that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for AWS GoLang SDK v2 request signer
3 participants