-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix observability event analytics and notebook failing tests #949
Conversation
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-949-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b7c9ad26342ff7edb2a8086ec09fd39e5bcc5ec
# Push it to GitHub
git push --set-upstream origin backport/backport-949-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-949-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b7c9ad26342ff7edb2a8086ec09fd39e5bcc5ec
# Push it to GitHub
git push --set-upstream origin backport/backport-949-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
@mengweieric Could you help me to understand the relation between this PR and #948? Is #948 still needed consider #949 has |
I was asked to post fixes directly to 2.11 then backport to main, but later realized that 2.11 tests are different than tests in main therefore posting a PR to fix main differently. |
I see, thanks for the reply :) |
Description
#948
Fix observability event analytics and notebook failing tests.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.