Fix flaky observability/4_panels tests #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiddis
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
looking |
|
This fails locally for me, would you be able to provide a screen of a successful test run against the current 2.11 RC? |
|
Screenshot for Cypress run on 4_panels with current RC (needs observability and SQL plugins)
|
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
fix-obs-tests
branch
from
a5e697b to
dbc63ce
Compare
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
kavilla
approved these changes
Oct 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix broken 4_panels test delays Signed-off-by: Simeon Widdis <[email protected]> * Recompute yarn.lock Signed-off-by: Simeon Widdis <[email protected]> * Remove added yarn.lock entirely Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 31c9fe9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix broken 4_panels test delays Signed-off-by: Simeon Widdis <[email protected]> * Recompute yarn.lock Signed-off-by: Simeon Widdis <[email protected]> * Remove added yarn.lock entirely Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 31c9fe9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some tests in 4_panels that are flaky due to poor delay configuration. I've modified the waits to check for conditions instead of waiting a fixed delay.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.