-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [bug] update installation commands in DEVELOPER_GUIDE.md #912
Conversation
Signed-off-by: qiwen li <[email protected]> (cherry picked from commit e53ba8e)
Hi. Yes, but I am confused about what name and email we can use for signing off... I did sign off the commit, but just with a different name and email. I used the same name and email for sign-off when contributing to other OpenSearch repos. I found out other OpenSearch repos only require all commits to be signed off but don't specify the name and the email has to be "@users.noreply.github.com". Do I need to change my local git config to that name and email? |
can you check your email settings of github with link https://github.com/settings/emails, that should be the same one with signing off |
I just checked, It is actually the same email but in my GitHub email setting, I enabled "Keep my email addresses private". Now I disabled it, also I changed my GitHub profile name to match the local git config. I think now it should be able to pass the DCO check... Is there a way to trigger the DCO check again? |
can you try with following steps as suggested
|
To get a local copy of this PR run |
Thank you so much!! |
Backport e53ba8e from #908