-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ftrepo to accept custom browser path running integTest #678
Merged
peterzhuamazon
merged 1 commit into
opensearch-project:main
from
peterzhuamazon:add_windows_custom_chromium_path_integtest
May 25, 2023
Merged
Allow ftrepo to accept custom browser path running integTest #678
peterzhuamazon
merged 1 commit into
opensearch-project:main
from
peterzhuamazon:add_windows_custom_chromium_path_integtest
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang and
ashwin-pc
as code owners
May 25, 2023 20:52
42 tasks
CCongWang
approved these changes
May 25, 2023
bbarani
approved these changes
May 25, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-678-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ddabc9edba20f3f90b6e788acd749989ae7d8926
# Push it to GitHub
git push --set-upstream origin backport/backport-678-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit ddabc9e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit ddabc9e)
peterzhuamazon
added a commit
that referenced
this pull request
May 25, 2023
…679) Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit ddabc9e) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
May 25, 2023
…680) Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit ddabc9e) Co-authored-by: Peter Zhu <[email protected]>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
…rch-project#678) (opensearch-project#680) Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit ddabc9e) Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow ftrepo to accept custom browser path running integTest
Issues Resolved
opensearch-project/opensearch-build#3434
opensearch-project/opensearch-ci#293
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.