Disable datasource management in Cypress configuration #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Su <[email protected]>
zhongnansu
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc and
peterzhuamazon
as code owners
CCongWang
approved these changes
Apr 14, 2023
yibow98
approved these changes
Apr 14, 2023
kavilla
approved these changes
Apr 14, 2023
1 task
ashwin-pc
added a commit
to ashwin-pc/opensearch-dashboards-functional-test
that referenced
this pull request
Apr 19, 2023
…earch-project#613)" This reverts commit 5842236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable datasource management in Cypress configuration. Since data source feature is by default disabled in OSD, it should also be disabled by default in cypress.json. However, the related test will still run, since in the workflow, we explicitly set the env variables, and enabled the feature when setting up test server
Issues Resolved
opensearch-project/OpenSearch-Dashboards#3843
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.