Simplify api response info for FF tests #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
tianleh,
kavilla,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
1 task
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
reviewed
Dec 5, 2024
| @@ -132,20 +132,8 @@ describe('Creating Workflows Using Various Methods', () => { | |||
| .should('be.visible') | |||
| .click(); | |||
| cy.fixture(FF_FIXTURE_BASE_PATH + 'semantic_search/ingest_response').then( | |||
There was a problem hiding this comment.
Tyler, In the fixture please remove filesemantic_search/ingest_response. As it is no longer used.
There was a problem hiding this comment.
Prefer to leave actually, so we're mocking correctly. Also, it actually is still required, as once ingest responses are returned, we have logic to to open up and auto-switch tabs to ingest or search, so the visibility check is still valid.
In the future, we may add some more flexible logic to parse out the responses and ensure there are visible parts in them as well.
saimedhi
reviewed
Dec 5, 2024
cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js
Show resolved
Hide resolved
saimedhi
reviewed
Dec 5, 2024
saimedhi
approved these changes
Dec 5, 2024
|
wanglam
approved these changes
Dec 6, 2024
raintygao
approved these changes
Dec 6, 2024
yubonluo
approved these changes
Dec 6, 2024
Merged
1 task
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c835903)
ohltyler
added a commit
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c835903) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some low-level checks on the responses from ingest/search caused some tests to fail after opensearch-project/dashboards-flow-framework#509
This PR simplifies the logic checking. How responses are rendered may soon change, which would require further changes later. Removing the lower-level checks to prevent flakiness and minimize test rewriting.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.