fix flaky test of query enhancement #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
abbyhu2000
approved these changes
Nov 15, 2024
abbyhu2000
reviewed
Nov 15, 2024
| @@ -108,7 +102,7 @@ describe('query enhancement queries', { scrollBehavior: false }, () => { | |||
| `source = timestamp-*` | |||
| ); | |||
| cy.waitForSearch(); | |||
| cy.getElementByTestId('queryResultCompleteMsg').click(); | |||
ashwin-pc
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Approving since @abbyhu2000 confirmed that this change is correct
ananzh
approved these changes
Nov 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 53f3bc5)
Hailong-am
added a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 53f3bc5) Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky test of query enhancement
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.