Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean query to make the test more robust #1601

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 23, 2024

Description

Observe the following issue sometimes in OSD CI.
image (3)

The bug is due to the query from a previous test response:200 is not cleaned out

it('should persist across refresh', function () {
      // Set up query and filter
      cy.setTopNavQuery('response:200');
      cy.submitFilterFromDropDown('extension.raw', 'is one of', 'jpg');
      cy.reload();
      cy.getElementByTestId(`queryInput`).should('have.text', 'response:200');
      cy.get('[data-test-subj~="filter-key-extension.raw"]').should(
        'be.visible'
      );
    });

Therefore we add a function to manual clean out the query to make the test more robust.

Screenshot 2024-10-23 at 12 20 06 PM

Issues Resolved

NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as test failures expected

@ashwin-pc ashwin-pc merged commit 0cca77b into opensearch-project:main Oct 25, 2024
44 of 66 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Anan <[email protected]>
(cherry picked from commit 0cca77b)
SuZhou-Joe pushed a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Anan <[email protected]>
(cherry picked from commit 0cca77b)

Co-authored-by: Anan Zhuang <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Anan <[email protected]>
(cherry picked from commit 0cca77b)
ananzh added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Anan <[email protected]>
(cherry picked from commit 0cca77b)

Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants