-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean query to make the test more robust #1601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anan <[email protected]>
ananzh
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
October 23, 2024 19:24
7 tasks
ashwin-pc
approved these changes
Oct 23, 2024
virajsanghvi
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as test failures expected
ruanyl
approved these changes
Oct 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Anan <[email protected]> (cherry picked from commit 0cca77b)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Anan <[email protected]> (cherry picked from commit 0cca77b) Co-authored-by: Anan Zhuang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Anan <[email protected]> (cherry picked from commit 0cca77b)
ananzh
added a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Anan <[email protected]> (cherry picked from commit 0cca77b) Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Observe the following issue sometimes in OSD CI.
The bug is due to the query from a previous test response:200 is not cleaned out
Therefore we add a function to manual clean out the query to make the test more robust.
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.