Add permission to allow copying to clipboard #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingyang(Abby) Hu <[email protected]>
abbyhu2000
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
approved these changes
May 7, 2024
|
Are we PRing to 2.14 just to verify that this work? |
|
existing failures unrelated. this should really do no harm even if it doesn't work. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 7, 2024
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js Issues Resolved resolves #1081 Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 64959fa)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 7, 2024
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js Issues Resolved resolves #1081 Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 64959fa)
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 8, 2024
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js Issues Resolved resolves #1081 Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 64959fa)
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 14, 2024
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js Issues Resolved resolves #1081 Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 64959fa) Co-authored-by: Qingyang(Abby) Hu <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 14, 2024
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js Issues Resolved resolves #1081 Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 64959fa) Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved
resolves #1081
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.