-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce 2-second delay to fix Cypress test failures #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
May 2, 2024 17:24
kavilla
approved these changes
May 2, 2024
CCongWang
approved these changes
May 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
[PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 79d98ca)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
[PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 79d98ca)
CCongWang
pushed a commit
that referenced
this pull request
May 2, 2024
[PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 79d98ca) Co-authored-by: Kaituo Li <[email protected]>
CCongWang
pushed a commit
that referenced
this pull request
May 2, 2024
[PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 79d98ca) Co-authored-by: Kaituo Li <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…roject#1261) [PR 1038](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1038/files) removed a 2-second delay in `cypress/utils/dashboards/vis-augmenter/commands.js`, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was a `TypeError` related to the `KeyboardEvent`, indicating that the expected input element was not ready at the time of interaction. Example error trace: ``` 1) Anomaly detection integration with vis augmenter Associate existing detector - creation flow: TypeError: Cannot read properties of undefined (reading 'KeyboardEvent') at Keyboard.fireSimulatedEvent (http://localhost:5601/__cypress/runner/cypress_runner.js:165273:28) at Keyboard.simulatedKeydown (http://localhost:5601/__cypress/runner/cypress_runner.js:165418:58) at Keyboard.typeSimulatedKey (http://localhost:5601/__cypress/runner/cypress_runner.js:165458:10) at http://localhost:5601/__cypress/runner/cypress_runner.js:165128:14 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Function.Promise.attempt.Promise.try (http://localhost:5601/__cypress/runner/cypress_runner.js:10296:29) at http://localhost:5601/__cypress/runner/cypress_runner.js:165138:67 at tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Object.gotValue (http://localhost:5601/__cypress/runner/cypress_runner.js:12164:18) at Object.gotAccum (http://localhost:5601/__cypress/runner/cypress_runner.js:12153:25) at Object.tryCatcher (http://localhost:5601/__cypress/runner/cypress_runner.js:13022:23) at Promise._settlePromiseFromHandler (http://localhost:5601/__cypress/runner/cypress_runner.js:10957:31) at Promise._settlePromise (http://localhost:5601/__cypress/runner/cypress_runner.js:11014:18) at Promise._settlePromise0 (http://localhost:5601/__cypress/runner/cypress_runner.js:11059:10) at Promise._settlePromises (http://localhost:5601/__cypress/runner/cypress_runner.js:11139:18) at Promise._fulfill (http://localhost:5601/__cypress/runner/cypress_runner.js:11083:18) ``` The test failures were observed in the ad anywhere related tests. CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476 This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests. **Testing Done:** 1. Confirmed that all related tests, including those in `ad anywhere`, now pass with the reintroduction of the delay. ``` (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 05:23 5 5 - - - │ │ s-plugin/vis_augmenter/associate_de │ │ tector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:00 3 3 - - - │ │ s-plugin/vis_augmenter/augment_vis_ │ │ saved_object_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 02:12 4 4 - - - │ │ s-plugin/vis_augmenter/view_anomaly │ │ _events_spec.js │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 09:35 12 12 - - - ``` Signed-off-by: Kaituo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1038 removed a 2-second delay in
cypress/utils/dashboards/vis-augmenter/commands.js
, which was intended to allow UI elements to render fully before interactions in Cypress tests. This removal led to test failures due to timing issues when typing in the dashboard name during the test execution. Specifically, the error encountered was aTypeError
related to theKeyboardEvent
, indicating that the expected input element was not ready at the time of interaction. Example error trace:The test failures were observed in the ad anywhere related tests.
CI Failure Details: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions/runs/8916683824/job/24488529476
This PR reinstates the 2-second wait, resolving the timing issue and ensuring that the necessary DOM elements are fully loaded before proceeding with the tests.
Testing Done:
ad anywhere
, now pass with the reintroduction of the delay.Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.