Use global tenant in vis_type_table and other tests #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anan <[email protected]>
ananzh
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
reviewed
Apr 8, 2024
| TABLE_INDEX_END_TIME, | ||
| toTestId, | ||
| } from '../../../../../utils/constants'; | ||
| // import { |
There was a problem hiding this comment.
I think we should fix this with the performance improvements with the table. However, I'm also in favor of not commenting these out as cypress shows how many we skipped which is a good metric to track and reduce. this will hide that stat.
There was a problem hiding this comment.
k. let me remove the comment out and assign myself to check it.
Signed-off-by: Anan <[email protected]>
Signed-off-by: Anan <[email protected]>
ashwin-pc
approved these changes
Apr 12, 2024
kavilla
approved these changes
Apr 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
Flaky tests due to loading time due to switch tenant. Currently set default tenant to global. * remove tenant fix for MD Partially resolves: opensearch-project/opensearch-build#4433 Signed-off-by: Anan <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 7b82031)
kavilla
pushed a commit
that referenced
this pull request
Apr 16, 2024
Flaky tests due to loading time due to switch tenant. Currently set default tenant to global. * remove tenant fix for MD Partially resolves: opensearch-project/opensearch-build#4433 Signed-off-by: Anan <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 7b82031) Co-authored-by: Anan Zhuang <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ct#1210) Flaky tests due to loading time due to switch tenant. Currently set default tenant to global. * remove tenant fix for MD Partially resolves: opensearch-project/opensearch-build#4433 Signed-off-by: Anan <[email protected]> Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flaky tests due to loading time due to switch tenant. Currently set default tenant to global.
Issues Resolved
Partial opensearch-project/opensearch-build#4433
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.