Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore video recording on Windows with DISABLE_VIDEO parameter #1142

Conversation

peterzhuamazon
Copy link
Member

Description

Restore video recording on Windows with DISABLE_VIDEO parameter

Issues Resolved

Closes opensearch-project/opensearch-build#4427

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member Author

Since these 2PRs Windows now fully support ffmpeg, thus we can re-enable this feature and introduce a param for user to disable it if needed.

Thanks.

Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement!

@peterzhuamazon peterzhuamazon marked this pull request as draft March 13, 2024 18:53
@peterzhuamazon peterzhuamazon marked this pull request as ready for review April 9, 2024 16:57
@peterzhuamazon peterzhuamazon merged commit 1a04ae2 into opensearch-project:main Apr 9, 2024
43 checks passed
@peterzhuamazon peterzhuamazon deleted the re-enable-ffmpeg-on-windows-runners branch April 9, 2024 16:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 9, 2024
peterzhuamazon added a commit that referenced this pull request Apr 9, 2024
… (#1211)

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 1a04ae2)

Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon added a commit that referenced this pull request Apr 9, 2024
… (#1212)

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 1a04ae2)

Co-authored-by: Peter Zhu <[email protected]>
LDrago27 pushed a commit to LDrago27/opensearch-dashboards-functional-test that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Windows Docker Container failed with ffmpeg missing libs
3 participants