Add download_chromium to integtest.sh for standalone chromium installation #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
peterzhuamazon
changed the title
1 task
Signed-off-by: Peter Zhu <[email protected]> Update scripts Signed-off-by: Peter Zhu <[email protected]> Add browser_downloader.sh independent of runtime env for cypress tests Signed-off-by: Peter Zhu <[email protected]> Add more Signed-off-by: Peter Zhu <[email protected]> Add more Signed-off-by: Peter Zhu <[email protected]> Add more Signed-off-by: Peter Zhu <[email protected]> Add download_chromium to integtest.sh for standalone chromium installation Signed-off-by: Peter Zhu <[email protected]> Add more Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
chromium-lock-112
branch
from
99702f4 to
96da3b2
Compare
prudhvigodithi
approved these changes
Feb 23, 2024
SuZhou-Joe
approved these changes
Feb 26, 2024
|
@peterzhuamazon Need backport 2.x? |
Hailong-am
approved these changes
Feb 26, 2024
Yes, already added label to the backports, 1.3 as well. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a)
peterzhuamazon
added a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Feb 26, 2024
Update scripts Add browser_downloader.sh independent of runtime env for cypress tests Add more Add more Add more Add download_chromium to integtest.sh for standalone chromium installation Add more Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 463125a) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Feb 27, 2024
peterzhuamazon
added a commit
to opensearch-project/opensearch-build
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add download_chromium to integtest.sh for standalone chromium installation
Issues Resolved
Closes: opensearch-project/opensearch-build#4459
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.