-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assistant failed cases because of change of ml-commons #1110
Merged
SuZhou-Joe
merged 5 commits into
opensearch-project:main
from
SuZhou-Joe:fix/assistant-main
Feb 19, 2024
Merged
Fix assistant failed cases because of change of ml-commons #1110
SuZhou-Joe
merged 5 commits into
opensearch-project:main
from
SuZhou-Joe:fix/assistant-main
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
xluo-aws,
Hailong-am,
ruanyl,
wanglam and
raintygao
as code owners
February 18, 2024 11:49
Signed-off-by: SuZhou-Joe <[email protected]>
raintygao
approved these changes
Feb 18, 2024
Hailong-am
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for helping fix this
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* feat: change matching prompt string Signed-off-by: SuZhou-Joe <[email protected]> * feat: add file Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 60e2503)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* feat: change matching prompt string Signed-off-by: SuZhou-Joe <[email protected]> * feat: add file Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 60e2503)
SuZhou-Joe
added a commit
that referenced
this pull request
Feb 19, 2024
…1111) * feat: change matching prompt string Signed-off-by: SuZhou-Joe <[email protected]> * feat: add file Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 60e2503) Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Feb 19, 2024
…1112) * feat: change matching prompt string Signed-off-by: SuZhou-Joe <[email protected]> * feat: add file Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> * fix: traces update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 60e2503) Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ml-commons changes the prompt when using tool in agent framework
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.