Update notebooks tests #1001
Merged
Update notebooks tests #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Local run results6_notebooks.spec.js.mp4 |
joshuali925
approved these changes
Jan 19, 2024
|
@Hailong-am, @wanglam Can you please review this PR? The dependent PR in dashboards-observability is merged in. |
wanglam
reviewed
Jan 20, 2024
| const moveToTestNotebook = () => { | ||
| cy.visit(`${BASE_PATH}/app/observability-notebooks#/`, { | ||
| timeout: delayTime * 3, | ||
| }); | ||
|
|
||
| // Reload page to load notebooks if they are not flushed in OpenSearch index yet. | ||
| cy.reload(); |
There was a problem hiding this comment.
Shall we check if they are already flushed?
There was a problem hiding this comment.
or should we force flush the index before load?
There was a problem hiding this comment.
This is a good suggestion, will look further on how to use the flush API here. The current issue is when page loads and the Flush is in process, browser loads an empty notebooks home page. I'll check if there's a way for force flush via cypress requests. Not sure, if there's a way to check if the flush process is complete as it is auto triggered for the observability index.
|
|
||
| describe('clean up all test data', () => { | ||
| it('Cleans up test notebooks', () => { |
There was a problem hiding this comment.
Nit: Shall we record the created notebook ids and just clear these items?
Hailong-am
approved these changes
Jan 22, 2024
| const moveToTestNotebook = () => { | ||
| cy.visit(`${BASE_PATH}/app/observability-notebooks#/`, { | ||
| timeout: delayTime * 3, | ||
| }); | ||
|
|
||
| // Reload page to load notebooks if they are not flushed in OpenSearch index yet. | ||
| cy.reload(); |
There was a problem hiding this comment.
or should we force flush the index before load?
ruanyl
approved these changes
Jan 22, 2024
|
@ps48 Added |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1001-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1d3ca1ecef3e25777dbb850793db72d506f22f6
# Push it to GitHub
git push --set-upstream origin backport/backport-1001-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
@ps48 The backport to |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update notebooks tests, this PR depends on notebooks updates to be merged by this PR: opensearch-project/dashboards-observability#1367
Issues Resolved
#897
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.