Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config helper utility to improve modifying Jenkins CASC yaml #516

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

lewijacn
Copy link
Contributor

@lewijacn lewijacn commented Jan 8, 2025

Description

This feature adds a configHelper python utility script to make modifying the Jenkins CASC yaml easier to understand and test locally. This script replaces previous shell functionality to add authConfig into the jenkins.yaml and extends support to allow nested secret structures to be placed in the authConfig secret which unblocks the current OIC auth pattern which has had a breaking change that requires this nested structure.

Issues Resolved

#515

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @lewijacn. This looks promising and relatively safe compared to previous implementation 🙌

configHelper/configHelper/config_helper.py Outdated Show resolved Hide resolved
configHelper/configHelper/config_helper.py Outdated Show resolved Hide resolved
configHelper/configHelper/config_helper.py Outdated Show resolved Hide resolved
lib/compute/jenkins-main-node.ts Outdated Show resolved Hide resolved
configHelper/configHelper/config_helper.py Outdated Show resolved Hide resolved
lewijacn and others added 2 commits January 13, 2025 20:47
Co-authored-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
@lewijacn
Copy link
Contributor Author

lewijacn commented Jan 14, 2025

Thanks for the contribution @lewijacn. This looks promising and relatively safe compared to previous implementation 🙌

Thanks for the review, hopefully this will help make an easier and more testable path toward some initial main node setup stuff that we can leverage in the future.

As an aside, I think we can run the python tests pretty easily in a github action as a small follow-up

Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lewijacn

@gaiksaya
Copy link
Member

@rishabh6788 @Divyaasm Any concerns before I merge in an hour?

@gaiksaya gaiksaya merged commit 87a8a7b into opensearch-project:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants