Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added platform to manifests. #751

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 14, 2021

Signed-off-by: dblock [email protected]

Description

Continuing the effort to build on other platforms than Linux, #741.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested review from peternied and VachaShah October 14, 2021 22:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #751 (e6f4037) into main (7de6526) will increase coverage by 0.03%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   91.17%   91.21%   +0.03%     
==========================================
  Files          75       75              
  Lines        1984     1992       +8     
==========================================
+ Hits         1809     1817       +8     
  Misses        175      175              
Impacted Files Coverage Δ
src/run_assemble.py 92.30% <ø> (ø)
src/test_workflow/integ_test/local_test_cluster.py 87.06% <87.50%> (ø)
src/assemble_workflow/bundle_recorder.py 100.00% <100.00%> (ø)
src/build_workflow/build_recorder.py 100.00% <100.00%> (ø)
src/manifests/build_manifest.py 100.00% <100.00%> (ø)
src/manifests/bundle_manifest.py 100.00% <100.00%> (ø)
src/run_integ_test.py 95.65% <100.00%> (ø)
src/test_workflow/dependency_installer.py 100.00% <100.00%> (ø)
src/test_workflow/perf_test/perf_test_cluster.py 100.00% <100.00%> (ø)
src/test_workflow/test_args.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de6526...e6f4037. Read the comment docs.

Copy link
Contributor

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dblock dblock requested a review from kavilla October 15, 2021 17:44
@dblock dblock merged commit 326d59f into opensearch-project:main Oct 15, 2021
@dblock dblock deleted the assemble-platform branch October 15, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants