Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing maven artifacts for 1.1 #703

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Fixing maven artifacts for 1.1 #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48d3b62
Removed scripts that were added into their respective repos.
dblock Oct 6, 2021
69471a6
Removed PA and PA RCA from Maven publication.
dblock Oct 6, 2021
9aca227
Removed alerting that was moved to its repo.
dblock Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions scripts/components/alerting/build.sh
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions scripts/components/common-utils/build.sh
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions scripts/components/job-scheduler/build.sh
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions scripts/components/performance-analyzer-rca/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,3 @@ fi
[ -z "$OUTPUT" ] && OUTPUT=artifacts

./gradlew build -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -x test

mkdir -p $OUTPUT/maven/org/opensearch
./gradlew publishToMavenLocal -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT
cp -r ~/.m2/repository/org/opensearch/performanceanalyzer-rca $OUTPUT/maven/org/opensearch
Comment on lines -62 to -65
Copy link
Member

@saratvemulapalli saratvemulapalli Oct 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly: This would mean we are not going to publish maven artifacts for Perf-analyzer and Perf-analyzer RCA.
Is the product team ok with it?
cc: @elfisher @stockholmux @ahopp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way we have already released 1.1 so we cannot go and make changes in the artifacts or we'll end up with different ones in maven than what we've released. The only question now is whether these become part of 1.2, or some earlier patch release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. For 1.2 may lets create an issues for both of these components to onboard if they'd like to have maven artifacts published. This would be lost when we look few weeks from now.

Also this makes me think, we have to automate verifying maven artifacts are published and have the right signatures for every release, make sure all components we expect exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue on that, #700

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero problems with this @saratvemulapalli.

4 changes: 0 additions & 4 deletions scripts/components/performance-analyzer/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,3 @@ fi
./gradlew build -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -x test
mkdir -p $OUTPUT/plugins
cp ./build/distributions/*.zip $OUTPUT/plugins

mkdir -p $OUTPUT/maven/org/opensearch
./gradlew publishToMavenLocal -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT
cp -r ~/.m2/repository/org/opensearch/opensearch-performance-analyzer $OUTPUT/maven/org/opensearch