Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SA dashboards from 3.0 manifest #5154

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

gaiksaya
Copy link
Member

Description

Security-Analytics has been causing bootstrapping issues. See https://playground.nightly.opensearch.org/3x/app/login?
Opened an issue with the plugin team here opensearch-project/security-analytics-dashboards-plugin#1185
Tested locally and can see dashboards coming up without SA-Dashboards for 3.0.0

Also removed cronjob for 3.0.0 for integ-test notification as we are not running integ-test for 3.0.0 yet.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
Comment on lines -58 to -59
- name: securityAnalyticsDashboards
repository: https://github.com/opensearch-project/security-analytics-dashboards-plugin.git
Copy link
Member

@peterzhuamazon peterzhuamazon Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest comment it out instead of removing in case we forgot, you can add a line of comment about why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya merged commit 2a595f0 into opensearch-project:main Oct 29, 2024
12 checks passed
@gaiksaya gaiksaya deleted the remove-cron branch October 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants