Adding Jenkins ENV to Integration Test Job

[saratvemulapalli]

Description

Adding support for Jenkins AWS Role and Session to ENV for Integration Test Job

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #498 (6066165) into main (9032bdc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   69.31%   69.31%           
=======================================
  Files          58       58           
  Lines        1509     1509           
=======================================
  Hits         1046     1046           
  Misses        463      463           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9032bdc...6066165. Read the comment docs.

[gaiksaya]

nit: We should be specific with the naming. AWS_ROLE_ARN is very generic.
Maybe something like AWS_TEST_ROLE_ARN. I think we are good for now since this jenkinsfile is under integtest but for future

[owaiskazi19]

Nit: Can we name it as jenkins-integration-test-session

[saratvemulapalli]

nit: We should be specific with the naming. AWS_ROLE_ARN is very generic.
Maybe something like AWS_TEST_ROLE_ARN. I think we are good for now since this jenkinsfile is under integtest but for future

Yeah the downstream dependency needed it that way.
Ref: https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow#integration-tests

[gaiksaya]

nit: We should be specific with the naming. AWS_ROLE_ARN is very generic.
Maybe something like AWS_TEST_ROLE_ARN. I think we are good for now since this jenkinsfile is under integtest but for future

Yeah the downstream dependency needed it that way.
Ref: https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow#integration-tests

Yeah talking about the overall codebase here :)

[setiah]

nit: We should be specific with the naming. AWS_ROLE_ARN is very generic.
Maybe something like AWS_TEST_ROLE_ARN. I think we are good for now since this jenkinsfile is under integtest but for future

Yeah the downstream dependency needed it that way.
Ref: https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow#integration-tests

Yeah talking about the overall codebase here :)

Yeah, there has been some back n forth on the naming - #367 (comment).
I think we should rename this to TEST_WORKFLOW_ROLE_ARN and refactor the S3Bucket to read it always from the caller, which in this case would be test workflow components.

[gaiksaya]

nit: We should be specific with the naming. AWS_ROLE_ARN is very generic.
Maybe something like AWS_TEST_ROLE_ARN. I think we are good for now since this jenkinsfile is under integtest but for future

Yeah the downstream dependency needed it that way.
Ref: https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow#integration-tests

Yeah talking about the overall codebase here :)

Yeah, there has been some back n forth on the naming - #367 (comment).
I think we should rename this to TEST_WORKFLOW_ROLE_ARN and refactor the S3Bucket to read it always from the caller, which in this case would be test workflow components.

That conversation makes sense. Thanks!