Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from CentOS7 to AL2 for 2.15.0 #4738

Merged
merged 1 commit into from
May 30, 2024
Merged

Switch from CentOS7 to AL2 for 2.15.0 #4738

merged 1 commit into from
May 30, 2024

Conversation

peterzhuamazon
Copy link
Member

Description

Switch from CentOS7 to AL2 for 2.15.0

Issues Resolved

#4379

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon self-assigned this May 30, 2024
prudhvigodithi
prudhvigodithi reviewed May 30, 2024
View reviewed changes
manifests/2.15.0/opensearch-2.15.0.yml
@@ -5,7 +5,7 @@ build:
version: 2.15.0
ci:
image:
name: opensearchstaging/ci-runner:ci-runner-centos7-opensearch-build-v3
name: opensearchstaging/ci-runner:ci-runner-al2-opensearch-build-v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterzhuamazon, I assume this is the dockerfile right https://github.com/opensearch-project/opensearch-build/blob/main/docker/ci/dockerfiles/current/build.al2.opensearch.x64.arm64.dockerfile ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@prudhvigodithi
Copy link
Member

Coming from issue #4379 are we not going with RockyLinux8 or Almalinux? Looks to me like after some discussion we decided to move forward with amazonlinux for build images, am I right ?

@peterzhuamazon
Copy link
Member Author

Coming from issue #4379 are we not going with RockyLinux8 or Almalinux? Looks to me like after some discussion we decided to move forward with amazonlinux for build images, am I right ?

We are moving forward with AL2 for the next year until 2025/06.
If possible we are going to move knnlib with AL2 to its own stage and changing everything else with almalinux8.
The current stage is to test AL2 before making other changes to ensure knnlib can be run on glibc 2.26.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 4ebe613 into opensearch-project:main May 30, 2024
17 checks passed
@peterzhuamazon peterzhuamazon deleted the switch-al2-knn branch May 30, 2024 19:26
peterzhuamazon added a commit to peterzhuamazon/opensearch-build that referenced this pull request Jun 11, 2024
@peterzhuamazon
Revert "Switch from CentOS7 to AL2 for 2.15.0 (opensearch-project#4738)"
24ef6f1 
This reverts commit 4ebe613.
peterzhuamazon added a commit to peterzhuamazon/opensearch-build that referenced this pull request Jun 11, 2024
@peterzhuamazon
Revert "Switch from CentOS7 to AL2 for 2.15.0 (opensearch-project#4738)"
c93ed76 
This reverts commit 4ebe613.

Get centos7 back to replace al2 due to issues in k-NN in 2.15.0

Signed-off-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudhvigodithi prudhvigodithi prudhvigodithi approved these changes

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

@rishabh6788 rishabh6788 Awaiting requested review from rishabh6788 rishabh6788 is a code owner

@zelinh zelinh Awaiting requested review from zelinh zelinh is a code owner

@Divyaasm Divyaasm Awaiting requested review from Divyaasm Divyaasm is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

Assignees

@peterzhuamazon peterzhuamazon

Labels
distinguished-contributor docker release v2.15.0
Projects
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterzhuamazon @prudhvigodithi