Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2.15.0 test manifest + add async search bwc tests #4720

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented May 22, 2024

Signed-off-by: Finn Carroll [email protected]

Description

Create a test manifest for 2.15.0
Add async search bwc tests to 2.15.0 manifest

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @finnegancarroll, we haven't confirmed the BWC tests are running accurately on 3.0 as we don't really expect major version backward compatible. Right now we believe adding bwc tests to 2.x manifest should be the most reasonable.

@finnegancarroll finnegancarroll changed the title Add async search bwc to 3.0.0 manifest Create 2.15.0 test manifest + add async search bwc tests Jun 3, 2024
@finnegancarroll
Copy link
Contributor Author

Thanks @zelinh! I've created a test manifest for 2.15.0 and enabled the async search bwc tests there. Let me know if this is not the appropriate location.

@finnegancarroll finnegancarroll marked this pull request as ready for review June 3, 2024 17:44
@gaiksaya gaiksaya added the manifest-ci-check Run manifest ci check label Jun 3, 2024
@peterzhuamazon
Copy link
Member

I will add the osd test manifest later in this PR and merge together.
Thanks.

@peterzhuamazon
Copy link
Member

Hi @finnegancarroll ,

I added back the mistakenly deleted flow-framework section and also add a new OSD test manifest.
@zelinh could you help with the approval?

Thanks

@peterzhuamazon peterzhuamazon added release v2.15.0 manifest-ci-check Run manifest ci check and removed manifest-ci-check Run manifest ci check labels Jun 7, 2024
@peterzhuamazon peterzhuamazon merged commit b075230 into opensearch-project:main Jun 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants