-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install fonts on windows docker image for chromium-based browser and lock docker version #4417
Merged
peterzhuamazon
merged 3 commits into
opensearch-project:main
from
peterzhuamazon:win-integtest-2.12-3
Feb 6, 2024
Merged
Install fonts on windows docker image for chromium-based browser and lock docker version #4417
peterzhuamazon
merged 3 commits into
opensearch-project:main
from
peterzhuamazon:win-integtest-2.12-3
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
bug
Something isn't working
integtest
test
release
cicd
docker
windows
ci-test-automation
jenkins
Jenkins related issue
v2.12.0
labels
Feb 6, 2024
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
February 6, 2024 21:09
This was referenced Feb 6, 2024
peterzhuamazon
changed the title
Install fonts on windows docker image for chromium-based browser
Install fonts on windows docker image for chromium-based browser and lock docker version
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Zhu <[email protected]>
prudhvigodithi
approved these changes
Feb 6, 2024
Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install fonts on windows docker image for chromium-based browser and lock docker version
Issues Resolved
#4370
#4416
#4126
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.