Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added neural-search to 2.12 manifest #4268

Merged

Conversation

martin-gaievski
Copy link
Member

Description

Added neural-search to 2.12 manifest

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be7660d) 93.16% compared to head (8f28d23) 93.16%.
Report is 1 commits behind head on main.

❗ Current head 8f28d23 differs from pull request most recent head e36b0b3. Consider uploading reports for the commit e36b0b3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4268   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files         189      189           
  Lines        5973     5973           
=======================================
  Hits         5565     5565           
  Misses        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-gaievski
This file you are changing is the template that we used.
Could you change on this manifest which would be used for build? Thanks. https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.12.0/opensearch-2.12.0.yml

@martin-gaievski
Copy link
Member Author

thank you @zelinh I've moved changes to correct file, please check

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks failed because of incompatible gradle and jdk version.
Since we recently upgraded to JDK21/gradle 8.5, opensearch-project/OpenSearch#11003, you should also upgrade and test your plugin to see if it supports that.
Blocking this PR for now.
Thanks.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zelinh zelinh merged commit 537ccdb into opensearch-project:main Dec 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants