Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional benchmark command line args #4173

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add support for optional benchmark command line args #4173

merged 1 commit into from
Oct 26, 2023

Conversation

rishabh6788
Copy link
Collaborator

@rishabh6788 rishabh6788 commented Oct 25, 2023

Description

This PR

  • Adds support for --test-procedure, --exclude-tasks and --include-tasks command line arguments for opensearch-benchmark in the nightly benchmark workflow.
  • Adds support for customRoleArn parameter of opensearch-cluster-cdk to be able to use a custom IAM role curated for nightly benchmark runs. The value will be passed from config.yml file as it contains aws account information.

Issues Resolved

#4102 #4103

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4173 (956aac4) into main (48de658) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4173      +/-   ##
==========================================
+ Coverage   93.30%   93.31%   +0.01%     
==========================================
  Files         187      187              
  Lines        5777     5792      +15     
==========================================
+ Hits         5390     5405      +15     
  Misses        387      387              
Files Coverage Δ
src/test_workflow/benchmark_test/benchmark_args.py 100.00% <100.00%> (ø)
..._workflow/benchmark_test/benchmark_test_cluster.py 86.45% <ø> (ø)
...st_workflow/benchmark_test/benchmark_test_suite.py 100.00% <100.00%> (ø)

@rishabh6788 rishabh6788 merged commit 707a7aa into opensearch-project:main Oct 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants