Manually flushing maven cache during cleanup #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 59.04% 59.04%
=======================================
Files 38 38
Lines 1111 1111
=======================================
Hits 656 656
Misses 455 455 Continue to review full report at Codecov.
|
|
Still awaiting the test run from the Jenkins server before I attempt to merge |
gaiksaya
reviewed
Sep 7, 2021
| @@ -46,6 +46,7 @@ pipeline { | |||
| post() { | |||
| always { | |||
| cleanWs disableDeferredWipeout: true, deleteDirs: true | |||
| sh "rm -rf ~/.m2/" | |||
There was a problem hiding this comment.
Can we have this in a clean_up function in this script so we can add all the common stuff that needs to be removed in one place?
There was a problem hiding this comment.
Let's circle back and refactor the pipeline if it starts getting harder to understand, the cost to make a function hardly saves much real estate sadly
dblock
approved these changes
Sep 7, 2021
mch2
approved these changes
Sep 7, 2021
gaiksaya
approved these changes
Sep 8, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Nied [email protected]
Description
Previous clean up did clean up the workspace, but the shared maven local repository was not cleaned
Issues Resolved
#392
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.