-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows Container] Add Windows IntegTest support to Jenkins with Windows Docker Container #4027
Merged
peterzhuamazon
merged 4 commits into
opensearch-project:main
from
peterzhuamazon:windows-docker-integtest-jenkins-2
Sep 15, 2023
Merged
[Windows Container] Add Windows IntegTest support to Jenkins with Windows Docker Container #4027
peterzhuamazon
merged 4 commits into
opensearch-project:main
from
peterzhuamazon:windows-docker-integtest-jenkins-2
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
…search-project#4023) Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
integtest
release
cicd
docker
windows
jenkins
Jenkins related issue
v2.10.0
labels
Sep 15, 2023
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
September 15, 2023 18:56
peterzhuamazon
changed the title
Windows docker integtest jenkins 2
Add Windows IntegTest support to Jenkins with Windows Docker Container
Sep 15, 2023
peterzhuamazon
commented
Sep 15, 2023
@@ -99,7 +99,7 @@ def __setup_cluster_and_execute_test_config(self, config: str) -> int: | |||
config, | |||
self.test_recorder, | |||
) as (endpoint, port): | |||
self.pretty_print_message("Running integration tests for " + self.component.name) | |||
self.pretty_print_message("Running integration tests for " + self.component.name + " " + config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missed in the osd part but already in os part.
Codecov Report
@@ Coverage Diff @@
## main #4027 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 187 187
Lines 5674 5674
=======================================
Hits 5226 5226
Misses 448 448
|
This was referenced Sep 15, 2023
peterzhuamazon
changed the title
Add Windows IntegTest support to Jenkins with Windows Docker Container
[Windows Container] Add Windows IntegTest support to Jenkins with Windows Docker Container
Sep 15, 2023
gaiksaya
reviewed
Sep 15, 2023
gaiksaya
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Windows Container] Add Windows IntegTest support to Jenkins with Windows Docker Container
Issues Resolved
opensearch-project/opensearch-ci#281
#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.