Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Container] Use windows home dir as temp dir location #3951

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Aug 31, 2023

Description

[Windows Container] Use windows home dir as temp dir location

Issues Resolved

Closes opensearch-project/k-NN#1040
opensearch-project/opensearch-ci#281
#3743

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #3951 (9cb3457) into main (7232a94) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3951   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         187      187           
  Lines        5669     5673    +4     
=======================================
+ Hits         5219     5223    +4     
  Misses        450      450           
Files Changed Coverage Δ
src/system/temporary_directory.py 93.87% <100.00%> (+0.54%) ⬆️

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon merged commit 2942920 into opensearch-project:main Sep 5, 2023
@peterzhuamazon peterzhuamazon deleted the temp-dir-windows branch September 5, 2023 18:20
@peterzhuamazon peterzhuamazon changed the title Use windows home dir as temp dir location [Windows Container] Use windows home dir as temp dir location Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] k-NN failed to build due to long path in test and missing faiss file after upgrade
2 participants