-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python 3.9 Upgrade] Docker CI Images update 3.7 to 3.9 (Part 1) #3634
[Python 3.9 Upgrade] Docker CI Images update 3.7 to 3.9 (Part 1) #3634
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 181 181
Lines 5380 5381 +1
=======================================
+ Hits 4922 4923 +1
Misses 458 458 |
@peterzhuamazon Why don't we move to 3.10? Is it because it has too many breaking changes? |
Hi @rishabh6788. Python 3.9 has been tested on my local for 1+ months, and it is the default given version on al2023, and easily available on other OSes such as rockylinux8. It is very stable for several years and it is much more similar to 3.7/3.8 than 3.10. It is also only a year apart from 3.10 in terms of lts support. So considering all the circumstances it is the best option for us in terms of migration. Thanks. |
docker/ci/dockerfiles/current/build.centos7.opensearch-dashboards.x64.arm64.dockerfile
Show resolved
Hide resolved
Approving assuming the docker images have already been built and tested thoroughly. |
The process has changes and will build after merge. |
Need to investigate a bit as the 3.9.17 from custom repo is having some issues when loading libs compares to the 3.9.5 version coming from default universe repo Ubuntu2004. |
Similar to this and missing python-apt as the re-link is messing up with default 3.8 version on Ubuntu2004: https://stackoverflow.com/questions/69949591/modulenotfounderror-no-module-named-apt-pkg-installing-deadsnakes-repository |
Signed-off-by: Peter Zhu <[email protected]>
Seeing errors on the python compilation here on arm64:
|
Not sure why this is the case, as other 2 centos7 images goes to success, tho this release image is a bit of outlier as it tries to compile openssl 1.1.1 as well as glibc higher versions. |
Seems like if there are two servers running build on the same time it will cause this error, and seems random, it will go away once we have rockylinux8 replace centos7. |
Resolve python issues: |
Description
[Python 3.9 Update] Docker CI Images update 3.7 to 3.9 (Part 1).
There will be a part2 on the test ci images, this one is related to build ci images.
All the locales are removed to use the default ones:
Thanks.
Issues Resolved
#3351
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.