Bug fix for docker validation digest mismatch in arm64 #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Lu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3624 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 181 181
Lines 5380 5381 +1
=======================================
+ Hits 4922 4923 +1
Misses 458 458
|
jordarlu
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
prudhvigodithi
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are changing to use the Repo Digest in the manifest and the etag taken from the API response header for digest comparison.
Refered solution is at docker/hub-feedback#1925 (comment)
Issues Resolved
It was found in CI that the current digest validaiton fail in arm64 due to the API used to retrieve the digest and parsed has no difference between the x64/amd64 v.s arm64.
A referrence log is at https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-validation/detail/distribution-validation/2/pipeline/44/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.