Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.0.0 osd test manifest #3477

Merged
merged 1 commit into from
May 5, 2023
Merged

Add 3.0.0 osd test manifest #3477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions manifests/3.0.0/opensearch-dashboards-3.0.0-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
schema-version: '1.0'
name: OpenSearch Dashboards
ci:
image:
name: opensearchstaging/ci-runner:ci-runner-rockylinux8-opensearch-dashboards-integtest-v2
components:
- name: OpenSearch-Dashboards
bwc-test:
test-configs:
- with-security
- without-security
- name: notificationsDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: observabilityDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: reportsDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: ganttChartDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: queryWorkbenchDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: securityDashboards
integ-test:
test-configs:
- with-security
- without-security
Copy link
Member

@gaiksaya gaiksaya May 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think securityDashboards will have tests without-security. Can you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kavilla @tianleh Can you guys take a look and suggest changes to this?
Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging security dashboards maintainers: @cwperks @peternied @davidlago

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how these tests are being sourced, this file looks different from 2.7.0 version, https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.7.0/opensearch-dashboards-2.7.0-test.yml , has there been changes to the architecture?

There are security tests in the functionalTestDashboards repo, which allows for running with and without security enabled.

Copy link
Member

@gaiksaya gaiksaya May 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the architecture is changing. Thanks for asking this. Looks like we need to add documentation for new architecture! @Divyaasm Can you take this question up and also later take care of adding the documentation ?

Copy link
Collaborator Author

@Divyaasm Divyaasm May 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @peternied , we have recently updated the implemention for OSD integtests, this used to run in a sequential order for all the OSD component plugins listed in ftrepo based on functionalTestDashboards input earlier. Now OSD integtest works similar to OS intgtests. Refer the related PR's #3316 and #3465 to get an idea on the implementation changes.

We will now be able to to run this individually for each OSD component or all together at once in parallel from Jenkins perspective and update results individually for each component in the S3 bucket based on the updated test manifest similar to the current PR. Let me know if you have any questions.

This PR is just used to test the latest implementation from Prod Jenkins.

Thanks,
Divya Madala

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, well please go ahead and include the tests as has been done with other plugins. I am not certain this is correct, but I think its best to move forward with generation results than waiting on making a determination

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input!

- name: searchRelevanceDashboards
integ-test:
test-configs:
- with-security
- without-security
- name: customImportMapDashboards
integ-test:
test-configs:
- with-security
- without-security