Use default build script for reportsDashboards, observabilityDashboards, queryWorkbenchDashboards and remove customized build script

[rupal-bq]

Signed-off-by: Rupal Mahajan [email protected]

Description

• removed customized build script for reportsDashboards
• removed customized build script for observabilityDashboards
• removed customized build script for queryWorkbenchDashboards

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[gaiksaya]

Hi @rupal-bq What do you think about moving this build.sh in the respective repository? Its will be easier to manage too.
cc: @peterzhuamazon @dblock

[rupal-bq]

Hi @rupal-bq What do you think about moving this build.sh in the respective repository? Its will be easier to manage too. cc: @peterzhuamazon @dblock

Seems good idea to me if many plugins have special use cases to handle. But I am not sure what is required to do so.

[gaiksaya]

Just move the script under scripts folder. Example https://github.com/opensearch-project/alerting/tree/main/scripts
and delete from here

[codecov-commenter]

Codecov Report

Merging #3055 (0cb8109) into main (af1be01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3055   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         167      167           
  Lines        4602     4602           
=======================================
  Hits         4288     4288           
  Misses        314      314           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rupal-bq]

Just move the script under scripts folder. Example https://github.com/opensearch-project/alerting/tree/main/scripts and delete from here

Deleted the script from here. As the chromium is removed and the repo split is done, I think dashboards-reporting can now use the default script.

[gaiksaya]

@zelinh You okay with this change?

[zelinh]

LGTM.

[vmmusings]

@rupal-bq @zelinh Does removing the script will automatically trigger default build script. We want to remove for observability Dashboards as well?

[zelinh]

@rupal-bq @zelinh Does removing the script will automatically trigger default build script. We want to remove for observability Dashboards as well?

@vamsi-amazon Our current workflow actually have a list for place to look for the build script.

opensearch-build/src/paths/script_finder.py

Lines 61 to 76 in af1be01

	def find_build_script(cls, project: str, component_name: str, git_dir: str) -> str:
	paths = [
	os.path.realpath(os.path.join(cls.component_scripts_path, component_name, "build.sh")),
	os.path.realpath(os.path.join(git_dir, component_name, "build.sh")),
	os.path.realpath(os.path.join(git_dir, "build.sh")),
	os.path.realpath(os.path.join(git_dir, "scripts", "build.sh")),
	os.path.realpath(
	os.path.join(
	cls.default_scripts_path,
	project.replace(" ", "-").lower(),
	"build.sh",
	)
	),
	]
	return cls.__find_script("build.sh", paths)

If it doesn't find the build script from all of those location above, the last choice is to use the default build script.

[rupal-bq]

For dashboards-observability, I don't see a build script at https://github.com/opensearch-project/dashboards-observability.

I will update this PR to remove https://github.com/opensearch-project/opensearch-build/blob/main/scripts/components/observabilityDashboards/build.sh as well so default can be used