Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status syntax for gradle check #2907

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Nov 15, 2022

Signed-off-by: Kunal Kotwani [email protected]

Description

  • Fixes wrong sh syntax for status check with multiple conditions
  • Affected PR

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kotwanikunal kotwanikunal requested a review from a team as a code owner November 15, 2022 23:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #2907 (adf4daa) into main (7c3db88) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
+ Coverage   93.40%   93.72%   +0.31%     
==========================================
  Files         158      158              
  Lines        4414     4414              
==========================================
+ Hits         4123     4137      +14     
+ Misses        291      277      -14     
Impacted Files Coverage Δ
src/system/os.py 100.00% <0.00%> (+6.25%) ⬆️
src/system/temporary_directory.py 93.33% <0.00%> (+28.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit 174e9be into opensearch-project:main Nov 15, 2022
mnin added a commit to graylog-labs/opensearch-build that referenced this pull request Nov 16, 2022
# By Peter Zhu (8) and others
# Via GitHub
* upstream/main: (24 commits)
  Updated manifests. (opensearch-project#2894)
  Update ref for 2.4.0 with tags (opensearch-project#2906)
  Fix status syntax for gradle check (opensearch-project#2907)
  Add the consolidated release notes for 2.4.0 release (opensearch-project#2887)
  Revert set output command (opensearch-project#2903)
  Fix status code for gradle check with retry (opensearch-project#2902)
  Upgrade actions and remove deprecated set ouput commands (opensearch-project#2901)
  Update opensearch-2.4.0.yml (opensearch-project#2896)
  Resolve Window IntegTest copy and startup issues (opensearch-project#2892)
  Update IM ref to include fix (opensearch-project#2890)
  Fix manifest workflow failure (opensearch-project#2889)
  Install twine on clients image (opensearch-project#2884)
  Freeze the ref with commit ID (opensearch-project#2882)
  Add latest url update toggle on distribution workflows (opensearch-project#2881)
  Update promoteArtifacts to support win/zip and add timer for gradle check windows (opensearch-project#2869)
  Fix signing the artifacts for .asc signatures (opensearch-project#2850)
  Update the ref with 2.4 branch for OSD. (opensearch-project#2855)
  Update the OSD manifest with commit ID (opensearch-project#2862)
  Add gradle check support for windows agent (opensearch-project#2860)
  Add default copy for opensearch-dashboards yml and docker entrypoint (opensearch-project#2861)
  ...

# Conflicts:
#	scripts/components/OpenSearch-Dashboards/install.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants